Skip to content

Redact PDF: Find personal info works as an on/off switch #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kingrishabdugar merged 1 commit into from
Oct 5, 2026
Merged

Redact PDF: Find personal info works as an on/off switch #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/tools/redact-pdf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ export async function openRedactor(file: File, viewer: HTMLElement): Promise<Red
find.append(search, markAll);
const personal = button(t('rd.personal'));
personal.title = t('rd.personalHint');
personal.setAttribute('aria-pressed', 'false');
// On touch screens a finger scrolls by default; this switch makes it draw instead.
const draw = button(t('rd.draw'), 'redact-btn redact-draw');
draw.setAttribute('aria-pressed', 'false');
Expand Down Expand Up @@ -186,9 +187,16 @@ export async function openRedactor(file: File, viewer: HTMLElement): Promise<Red
refresh();
};

const same = (a: Box, b: Box) => a.x0 === b.x0 && a.y0 === b.y0 && a.x1 === b.x1 && a.y1 === b.y1;
// What "Find personal info" marked last, so the button shows as on while those marks are there
// and a second tap takes them off again.
let personalFound: Box[][] = [];
const isPersonal = (box: Box, index: number) => personalFound[index]?.some((found) => same(found, box));

function refresh() {
const total = marks.reduce((sum, page) => sum + page.length, 0);
count.textContent = t('rd.count', { n: total });
personal.setAttribute('aria-pressed', String(marks.some((page, i) => page.some((box) => isPersonal(box, i)))));
undo.disabled = !history.length;
clear.disabled = !total;
views.forEach(drawMarks);
Expand Down Expand Up @@ -293,7 +301,7 @@ export async function openRedactor(file: File, viewer: HTMLElement): Promise<Red
observer.observe(wrapper);
}

/** Marks what `find` picks out of every page's text; returns how many marks were added. */
/** Marks what `find` picks out of every page's text; returns every match, per page. */
async function markEverywhere(find: Finder, busy: HTMLButtonElement) {
busy.disabled = true;
const found: Box[][] = [];
Expand All @@ -309,22 +317,28 @@ export async function openRedactor(file: File, viewer: HTMLElement): Promise<Red
busy.disabled = false;
}
// Running the same search twice marks nothing twice.
const same = (a: Box, b: Box) => a.x0 === b.x0 && a.y0 === b.y0 && a.x1 === b.x1 && a.y1 === b.y1;
const fresh = found.map((page, i) => page.filter((box) => !marks[i].some((mark) => same(mark, box))));
if (fresh.some((page) => page.length)) change(marks.map((page, i) => [...page, ...fresh[i]]));
return found.reduce((sum, page) => sum + page.length, 0);
return found;
}
const sum = (pages: Box[][]) => pages.reduce((total, page) => total + page.length, 0);

find.onsubmit = async (event) => {
event.preventDefault();
const query = search.value.trim();
if (!query) return;
const total = await markEverywhere(occurrences(query), markAll);
const total = sum(await markEverywhere(occurrences(query), markAll));
count.textContent = total ? t('rd.found', { n: total }) : t('rd.none', { text: query });
};
personal.onclick = async () => {
const total = await markEverywhere(personalData, personal);
count.textContent = total ? t('rd.personalFound', { n: total }) : t('rd.personalNone');
if (personal.getAttribute('aria-pressed') === 'true') {
change(marks.map((page, i) => page.filter((box) => !isPersonal(box, i))));
return;
}
const found = await markEverywhere(personalData, personal);
personalFound = found;
refresh();
count.textContent = sum(found) ? t('rd.personalFound', { n: sum(found) }) : t('rd.personalNone');
};
undo.onclick = () => {
marks = history.pop() ?? marks;
Expand Down
17 changes: 13 additions & 4 deletions tests/app.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,12 +436,21 @@ test('finds and marks personal details in one click, and leaves amounts and date
expect(onLine, `mark at ${middle}`).toBe(true);
}

// A second click marks nothing twice.
await page.getByRole('button', { name: 'Find personal info' }).click();
// The button stays on while its marks are there; a second click takes them off again.
const personal = page.getByRole('button', { name: 'Find personal info' });
await expect(personal).toHaveAttribute('aria-pressed', 'true');
await personal.click();
await expect(marks).toHaveCount(0);
await expect(personal).toHaveAttribute('aria-pressed', 'false');
await page.getByRole('button', { name: 'Undo' }).click();
await expect(marks).toHaveCount(3);
await expect(personal).toHaveAttribute('aria-pressed', 'true');
await page.getByRole('button', { name: 'Clear all' }).click();
await expect(personal).toHaveAttribute('aria-pressed', 'false');
// Found again, nothing is marked twice.
await personal.click();
await expect(page.locator('.redact-count')).toHaveText('Personal details marked: 3. Check each one before saving.');
await expect(marks).toHaveCount(3);
await page.getByRole('button', { name: 'Undo' }).click();
await expect(marks).toHaveCount(0);
});

test('transcribes speech on the device, with a one-time setup, and writes text and subtitles', async ({ page, baseURL }) => {
Expand Down
Loading