fix: pin tiktoken version to >=0.7,<1.0 - #8
Open
xiaolai wants to merge 1 commit into
Open
Conversation
The UV inline script dependency and the fallback pip install instructions both referenced tiktoken with no version constraint. An unpinned runtime install allows arbitrary future versions, including breaking or malicious releases. Pins all three install paths to `tiktoken>=0.7,<1.0`, consistent with the current stable release series. Co-Authored-By: Claude Code <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
tiktokenis referenced without a version constraint in both the UV inline script spec (scan-codebase.pyline 4,# dependencies = ["tiktoken"]) and the fallbackpip install tiktokeninstructions inSKILL.md(lines 55, 57, 292–296). An unpinned runtime install resolves to the latest release on every cold run, allowing a future breaking or compromised release to affect users silently.Evidence:
scan-codebase.py:4—# dependencies = ["tiktoken"]— no specifier.SKILL.md—pip install tiktoken(×2 locations) — no specifier. Both confirmed by direct file inspection.Fix: Pins all references to
tiktoken>=0.7,<1.0, consistent with the current stable release series and the API surface used (cl100k_baseencoding, available since 0.3.x).