Repository navigation
Add BIQ shells for new principles - #78
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped preamble, test, and sync-record changes are consistent, with no blocking issues identified.
0 open findings
What changed in this PR
Syncs the existing USMC preamble from kindel/principles; no new shells or question banks are added.
Changes:
- Removes the traits URL while retaining the further-reading explanation.
- Updates the framing test and upstream sync record.
| File | Description |
|---|---|
| tests/test_framing.py | Checks the mnemonic and further-reading wording instead of the URL. |
| data/questions.json | Removes the traits URL from the USMC preamble. |
| .kindel/last-sync.txt | Records the upstream revision and preamble update. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 483bf58d66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BIQ copies the blog list from data/teaching/<company>/index.json onto the company shell and renders those links for the selected company. The USMC view links Leadership Traits to the official traits page, and the sync keeps the list on the next cascade.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59968a4938
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The framing check validates Further reading only when a shell has a blog list, so a new company from the principles index does not fail CI before its teaching file exists. The Further reading label uses the dark accent so the small caps clear 4.5:1 on the paper background.
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Company and principle shells from
kindel/principles.New companies land with
examples: falseand empty question lists.Existing banks are not rewritten. This does not generate example packs
and does not spend xAI credits.
Next, if a new company or principle showed up: write the questions,
run Generate example packs, review, then set
examples: true.See
.kindel/last-sync.txt.