Skip to content

Parsing exception fix #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-larraz merged 4 commits into from
Nov 12, 2025
Merged

Parsing exception fix #16

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b55caf5
Parsing errors now are handled within initialize. Simplifed error han…
Jabe03 Nov 7, 2025
c7cf27a
Removed exception throwing in analyze
Jabe03 Nov 7, 2025
669be38
Removed code that now goes unused
Jabe03 Nov 7, 2025
fa8a454
Revert back to old logic in callKind2
Jabe03 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/main/java/edu/uiowa/cs/clc/kind2/results/Result.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,31 +126,11 @@ private void analyze() {
if (root == null) {
// if the root object is null at this point, then we couldn't parse the json output properly.
// It makes sense to throw kind2 errors found in the log objects.
throwKind2Errors();
return;
}
root.analyze();
}

/**
* throw a {@link RuntimeException} if at least one of kind2 logs is error, fatal, or off.
*/
private void throwKind2Errors() {
StringBuilder stringBuilder = new StringBuilder();
stringBuilder
.append("An error has occurred during kind2 analysis. Please check the following logs:\n");
boolean someError = false;
for (Log log : kind2Logs) {
if (log.getLevel() == LogLevel.error || log.getLevel() == LogLevel.fatal
|| log.getLevel() == LogLevel.off) {
stringBuilder.append(log + "\n");
someError = true;
}
}
if (someError) {
throw new RuntimeException(stringBuilder.toString());
}
}

@Override
public String toString() {
Expand Down