Skip to content

[#981] Small changes - #1085

Open
Drevanoorschot wants to merge 49 commits into
mainfrom
feature/981_small-changes
Open

[#981] Small changes#1085
Drevanoorschot wants to merge 49 commits into
mainfrom
feature/981_small-changes

Conversation

@Drevanoorschot

@Drevanoorschot Drevanoorschot commented Aug 20, 2026

Copy link
Copy Markdown
Member

Closes #981

DOD checklist

For PR maintainer

Perform these checks before marking the PR as ready:

  • I have linked the PR to at least one issue.
  • I assigned the PR to myself.
  • I have added a description how to test this PR (see "Review Instructions").
  • [For bug fixes only] I have added a regression test for the fixed bug.
  • I have added documentation where necessary.

For reviewer

  • I have read all code changes.
  • I have audited the code quality.
  • I have tested the changes either or both:
    • locally
    • on the test environment (preferred)
  • I have validated that the PR is functionally correct (use-cases, figma designs, etc.)

Review instructions

Changes to review:

  • Basisgegevens > Type lijstaanduiding
    • hints are now distributed better on the page
  • Basisgegevens > Gegevens politieke groepering
    • Info box doesn't disappear anymore after selecting an option
  • Kandidatenlijsten > Kandidatenlijst
    • Aanpassen knop has new styling
    • Fix hover range of warning icon on candidate (i.e. ⚠️ and ℹ️, etc icon)
    • Button on bottom of the screen now goes to overview page
  • Kandidatenlijsten > Kandidatenlijst > Aanpassen
    • Delete button is always visible, regardless of screen size
  • Kandidatenlijsten > Kandidatenlijst > [Select a candidate] > Persoonlijke gegevens
    • Achternaam informatie pop over now has bullets
    • Woonplaats now gives BAG warnings
    • Woonplaats now suggests non Frisian aliases (i.e. Den Haag -> 'S-Gravenhage)
  • Kandidatenlijsten > Kandidatenlijst > [Select a candidate] > Volgorde op de lijst
    • Displays a warning when the number exceeds the max allowed candidates
  • Kandidatenlijsten > Kandidatenlijst > [Select a candidate] > Gemachtigde van kandidaat (after selecting a non-NL landcode in Persoonlijke gegevens)
    • Representative does not have a first name anymore
  • Afronden
    • Removed header text
    • Step 2 now has an explanation about EML210

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Sigrid maintainability feedback


🔒Enable security insights in your CI pipeline to detect vulnerabilities early.
Start using Sigrid CI for Security today. Learn more.


✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-08-27.

👍 What went well?

You fixed or improved 5 refactoring candidates.

Risk System property Location
🔴 Duplication
(Fixed)
src/pg/common/forms/name.rs line 14-19
src/pg/common/forms/name.rs line 45-50
🔴 Duplication
(Fixed)
frontend/styles/steps.css line 47-56
frontend/styles/finalise.css line 181-190
🔴 Duplication
(Fixed)
src/pg/candidates/pages/update_position.rs line 70-77
src/pg/candidates/pages/update_representative.rs line 69-76
🟠 Unit Size
(Improved)
src/pg/candidate_lists/candidate_record.rs
CandidateRecordCsv.from(Person)
🟠 Unit Size
(Improved)
src/pg/candidate_lists/candidate_record.rs
CandidateRecord.from(CandidateRecordCsv)

👎 What could be better?

Unfortunately, 14 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
frontend/styles/steps.css line 48-57
frontend/styles/finalise.css line 181-190
🔴 Duplication
(Introduced)
src/pg/candidates/pages/update_representative.rs line 69-76
src/pg/candidates/pages/update_position.rs line 94-101
🔴 Duplication
(Introduced)
src/csb/examination/pages/delete.rs line 16-21
src/csb/examination/pages/political_group.rs line 30-35
🔴 Duplication
(Introduced)
src/pg/common/forms/name.rs line 14-19
src/pg/common/forms/name.rs line 49-54
🔴 Unit Interfacing
(Worsened)
src/pg/candidates/pages/update.rs
update_person_submit(CandidateListUpdatePersonPath,Context,FullCandidateList,Candidate,PgStore,Query<QueryParamState>,Form<PersonalDataForm>)
🔴 Module Coupling
(Worsened)
src/structs/common/place_of_residence.rs
🟠 Unit Size
(Worsened)
frontend/scripts/form-inputs/locality-suggestions.ts
runUpdate(boolean)
🟠 Unit Size
(Worsened)
frontend/scripts/form-inputs/locality-suggestions.ts
locality-suggestions.ts.localitySuggestions()
⚪️ + 6 more

📚 Remaining technical debt

7 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-08-27 Before changes New/changed code
Duplication 5.3 4.9 4.8
Unit Size 3.3 3.5 3.7
Unit Complexity 4.6 5.0 5.0
Unit Interfacing 2.5 1.6 1.7
Module Coupling 3.0 2.4 2.4
Component Independence 5.5 5.5 5.5
Component Entanglement N/A N/A N/A
Maintainability 4.0 3.7 3.8

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@github-actions

Copy link
Copy Markdown

PDF diff summary

Template Input Status
model-h1 model-h1-example-1.pdf 🔵 identical
model-h1 model-h1-example-2.pdf 🔵 identical
model-h1 model-h1-example-3.pdf 🔵 identical
model-h3-1 model-h3-1-example-1.pdf 🔵 identical
model-h3-1 model-h3-1-example-2.pdf 🔵 identical
model-h3-1 model-h3-1-example-3.pdf 🔵 identical
model-h3-2 model-h3-2-example-1.pdf 🔵 identical
model-h3-2 model-h3-2-example-2.pdf 🔵 identical
model-h3-2 model-h3-2-example-3.pdf 🔵 identical
model-h4 model-h4-example-1.pdf 🔵 identical
model-h4 model-h4-example-2.pdf 🔵 identical
model-h4 model-h4-example-3.pdf 🔵 identical
model-h9 model-h9-example-1.pdf 🔵 identical
model-h9 model-h9-example-2.pdf 🔵 identical
model-h9 model-h9-example-3.pdf 🔵 identical
model-i1 model-i1-example-1.pdf 🔵 identical
model-i1 model-i1-example-2.pdf 🔵 identical
model-i4 model-i4-example-1.pdf 🔵 identical
model-i4 model-i4-example-2.pdf 🔵 identical

Base automatically changed from pw-reorder-folder-structure to main August 25, 2026 08:32
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small changes after testing 20-07

5 participants