Skip to content

[#1089] Way of working quality - #1075

Merged
I-KS merged 10 commits into
mainfrom
way-of-working-quality
Aug 27, 2026
Merged

[#1089] Way of working quality#1075
I-KS merged 10 commits into
mainfrom
way-of-working-quality

Conversation

@I-KS

@I-KS I-KS commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Closes #1089

DOD checklist

For PR maintainer

Perform these checks before marking the PR as ready:

  • I have linked the PR to at least one issue.
  • I assigned the PR to myself.
  • I have added a description how to test this PR (see "Review Instructions").
  • I have added documentation where necessary.

For reviewer

  • I have read all code changes.
  • I have audited the code quality.
  • I have tested the changes either or both:
    • locally
    • on the test environment (preferred)
  • I have validated that the PR is functionally correct (use-cases, figma designs, etc.)

Review instructions

read document

I-KS added 3 commits August 11, 2026 14:22
Added section on Continuous Integration / Continuous Delivery (CI/CD) and updated CI/CD pipeline quality gates.
@github-actions

Copy link
Copy Markdown

Sigrid maintainability feedback


🔒Enable security insights in your CI pipeline to detect vulnerabilities early.
Start using Sigrid CI for Security today. Learn more.


💭️ You did not change any files that are analyzed by Sigrid.


View this system in Sigrid

Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Comment thread docs/werkwijze-kwaliteit-waarborgen.md Outdated
Co-authored-by: Dré van Oorschot <dre.van.oorschot@technolution.nl>
Added key quality attributes and expanded testing section.
Added details on issue creation and testing process involving internal and external stakeholders.
Added information about SIG and SonarQube for automated code quality analysis in the CI/CD pipeline.
@kiesraad kiesraad deleted a comment from Drevanoorschot Aug 20, 2026
@I-KS I-KS changed the title Way of working quality [#1089] Way of working quality Aug 20, 2026
@I-KS I-KS self-assigned this Aug 20, 2026
@I-KS
I-KS marked this pull request as ready for review August 20, 2026 11:44
@marlonbaeten

Copy link
Copy Markdown
Contributor

@I-KS I added a commit with some typo fixes and factual corrections.

@sonarqubecloud

Copy link
Copy Markdown

@I-KS I-KS left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks voor je aanvullingen Marlon, echt top!

@I-KS
I-KS merged commit 0fd3895 into main Aug 27, 2026
19 checks passed
@I-KS
I-KS deleted the way-of-working-quality branch August 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Way of working e-KS update

3 participants