[#1099] Generate election definition - #1015
Draft
michielp1807 wants to merge 4 commits into
Draft
Conversation
Sigrid maintainability feedback🔒Enable security insights in your CI pipeline to detect vulnerabilities early. ✅ You wrote maintainable code and achieved your objective of 3.5 stars. Show detailsSigrid compared your code against the baseline of 2026-08-27. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
PDF diff summary
|
michielp1807
force-pushed
the
eml110a
branch
6 times, most recently
from
August 25, 2026 09:22
702884e to
9b44ca0
Compare
michielp1807
had a problem deploying
to
development
August 25, 2026 09:22 — with
GitHub Actions
Failure
michielp1807
temporarily deployed
to
development
August 25, 2026 09:22 — with
GitHub Actions
Inactive
michielp1807
had a problem deploying
to
development
August 25, 2026 09:22 — with
GitHub Actions
Failure
michielp1807
temporarily deployed
to
development
August 25, 2026 09:36 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 09:36 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 09:36 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 09:48 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 09:48 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 09:48 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 10:17 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 10:17 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 25, 2026 10:17 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 27, 2026 07:21 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 27, 2026 07:21 — with
GitHub Actions
Inactive
michielp1807
temporarily deployed
to
development
August 27, 2026 07:21 — with
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


DOD checklist
TODO:
max_votesis always an empty tag? Seems to be the case in the files I checked.Committees to the election treeCouncil'sNumberOfSeatsinstead of configuring it in the election config? -> PS/WS don't have theNumberOfSeatsspecified in the MET currently, maybe add it? -> No, it is the responsibility of the GR/PS/WS to define their ownNumberOfSeats-> eventually we should allow them to configure this in e-KS<Region RegionNumber="9010" RegionCategory="GEMEENTE">- it doesn't show up in PS23 -> this is the "Nationaal Brief Stembureau"Converting
MasterElectionTree.xml(MET) =>ElectionTreeRegionfor election ("STAAT" for EK/TK)Committees for the currentElectionCategorySee kiesraad/rust-eml-nl#41 (comment):
(MET parsing still needs to be build)
The MET also includes two new region types:
This PR also configures the CI to run cargo clippy and cargo test on the entire workspace.
For PR maintainer
Perform these checks before marking the PR as ready:
For reviewer
Review instructions