Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix attribute-based XSS in HTML escaping#1237

Open
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/fix-escapehtml-xss-4045965761129508026
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix attribute-based XSS in HTML escaping#1237
khangnghiem wants to merge 1 commit into
mainfrom
sentinel/fix-escapehtml-xss-4045965761129508026

Conversation

@khangnghiem

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The custom HTML escaping function (escHtml) in site/layers.js failed to cast inputs correctly using String() and entirely missed escaping single quotes (').
🎯 Impact: This allowed attribute-based Cross-Site Scripting (XSS). If user-controlled input containing a single quote was fed into this function and rendered inside an HTML attribute (e.g. data-node-id='@userInput'), the attacker could break out of the attribute and inject malicious event handlers or structural elements, leading to arbitrary JavaScript execution.
πŸ”§ Fix: Added String() casting to ensure inputs are handled correctly, and added string replacement to escape single quotes (') as ' within the escHtml function. Appended a journal entry logging the pattern.
βœ… Verification: Ran grep to verify the patch and node --check to confirm syntax correctness. Ran vitest in fd-vscode where similar fixes were made to ensure no regressions. Code review returned #Correct#.


PR created automatically by Jules for task 4045965761129508026 started by @khangnghiem

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant