Fix build and update dependencies to latest#20
Closed
lopopolo wants to merge 2 commits into
Closed
Conversation
This PR updates all all `dependencies` and `devDependencies` to the latest versions and updates tests so they build with the latest `devDependencies`. There is a breaking change to update `engines` to `>=7.6.0` due to an `xo` lint. Exported functions are now `async` functions. `npm test` exits with a non-zero exit code from `ava` that I'm not sure how to address.
Author
|
@sindresorhus it looks like you have commit access to this repository. I'm hoping you have release permissions too. My motivation with this PR is to remove the ancient version of |
Author
|
I know this is a hack and can't be merged, but adding a const exec = (cmd, cwd) => pMapSeries(cmd, x => {
console.log(x);
return execa(x, {cwd, shell: true});
});I'm not sure why this makes things work or why there was no stack trace or promise rejection before. It looked like |
Author
|
It looks like |
Author
|
See also kevva/bin-check#4. |
This was referenced Jan 10, 2021
Author
|
See also kevva/exec-buffer#10. |
Author
|
This Pr obsoletes #17. |
This was referenced Jan 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all all
dependenciesanddevDependenciesto thelatest versions and updates tests so they build with the latest
devDependencies.There is a breaking change to update
enginesto>=7.6.0due to anxolint. Exported functions are nowasyncfunctions.npm testexits with a non-zero exit code fromavathat I'm not surehow to address.