Scan updates & robustness#39
Merged
Merged
Conversation
kernelcoffee
commented
Jul 18, 2026
Owner
- Drift detection: a listing page that parses to zero giveaways without SteamGifts' 'No results were found.' marker (pagination--no-results) now raises SteamGiftsScrapeDriftError instead of silently returning an empty list; the sync logs it as a warning in the activity log. Captured a real empty-search page as a sanitized fixture
- Wishlist scans now use max_scan_pages (was hardcoded 1 page) with early stop: an empty or short (<50 rows) page ends any scan, so small lists still cost a single request
- After a complete wishlist scan (end of list actually seen), active giveaways flagged is_wishlist that no longer appear lose the flag (game removed from Steam wishlist); expired rows keep the flag as history, and partial or drift-aborted scans never un-stick anything
…tick - Drift detection: a listing page that parses to zero giveaways without SteamGifts' 'No results were found.' marker (pagination--no-results) now raises SteamGiftsScrapeDriftError instead of silently returning an empty list; the sync logs it as a warning in the activity log. Captured a real empty-search page as a sanitized fixture - Wishlist scans now use max_scan_pages (was hardcoded 1 page) with early stop: an empty or short (<50 rows) page ends any scan, so small lists still cost a single request - After a complete wishlist scan (end of list actually seen), active giveaways flagged is_wishlist that no longer appear lose the flag (game removed from Steam wishlist); expired rows keep the flag as history, and partial or drift-aborted scans never un-stick anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.