Repository navigation
fix: default to Recreate strategy and allow CNPG plugins - #82
Merged
Merged
Conversation
- Add paperless.strategy and redis.strategy (default: Recreate) so upgrades with ReadWriteOnce PVCs no longer hit Multi-Attach errors. Render `rollingUpdate: null` for Recreate so existing releases upgrade cleanly. Closes #79 - Add cnpg.plugins, rendered into the Cluster spec.plugins, to register CNPG-I plugins such as barman-cloud for backups / WAL archiving. Closes #77 - Bump chart version to 1.8.1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QD1kFPcmFFoZmmgw6t4XGw
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QD1kFPcmFFoZmmgw6t4XGw
Owner
Author
|
I re-ran the failed job once. If it keeps flaking, the fix is to make the smoke test robust, e.g. retry the curl in a loop, or use Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paperless.strategyandredis.strategyvalues, defaulting totype: Recreate, so upgrades withReadWriteOncePVCs no longer get stuck onMulti-Attacherrors. ForRecreate, the chart rendersrollingUpdate: nullso existing releases (whose live Deployment still carries the defaultrollingUpdateblock) upgrade without the API server rejecting the change. Settype: RollingUpdateto opt back in (RWX volumes).cnpg.pluginslist, rendered asspec.pluginson the CNPGCluster, to register CNPG-I plugins such asbarman-cloud.cloudnative-pg.iofor backups / WAL archiving.Closes #79
Closes #77
Testing
helm lintwithci/ct-values.yamlhelm templatechecked: default (Recreate +rollingUpdate: null),RollingUpdate, strategy set to null (field omitted), andcnpg.pluginspopulated🤖 Generated with Claude Code
https://claude.ai/code/session_01QD1kFPcmFFoZmmgw6t4XGw
Generated by Claude Code
Summary by cubic
Fixes upgrade stalls on
ReadWriteOncePVCs by defaulting to aRecreateupdate strategy, and adds support for registering CNPG-I plugins.paperless.strategyandredis.strategyvalues default totype: Recreate, preventingMulti-Attacherrors when pods move to a new node. ForRecreate, the chart rendersrollingUpdate: nullso existing Deployments upgrade cleanly. Settype: RollingUpdateto opt back in (requires RWX volumes).cnpg.pluginslist is rendered asspec.pluginson the CNPGCluster, enabling plugins likebarman-cloud.cloudnative-pg.iofor backups and WAL archiving. Requires CNPG >= 1.26 and the plugin deployed separately.Closes #79 and #77.
Written for commit 2ef4912. Summary will update on new commits.