[kernel-1027] update neko client to have optional debugging#163
Merged
archandatta merged 3 commits intomainfrom Feb 25, 2026
Merged
[kernel-1027] update neko client to have optional debugging#163archandatta merged 3 commits intomainfrom
archandatta merged 3 commits intomainfrom
Conversation
rgarcia
reviewed
Feb 25, 2026
| if (isDebugEnabled()) { | ||
| client.on('debug', window.$log.debug) | ||
| } | ||
| window.$client = client |
Contributor
There was a problem hiding this comment.
i think we should be able to turn off all logging so maybe the query param should be a more generic log level, and it should default to completely off
rgarcia
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Scoped to client-side console logging; main risk is reduced observability if the query param isn’t set or is mis-typed (logs become no-ops).
Overview
The client’s
$logplugin is changed from always-on console logging to a level-gated logger that is disabled by default.Logging can now be enabled per-session via
?log_level=(or?logLevel=), supportingoff/none/empty (fully silent) and incremental levels (error->warn->info->debug) by mapping lower-priority methods to no-ops.Written by Cursor Bugbot for commit 6c22f62. This will update automatically on new commits. Configure here.