Delete should also attempt graceful stop before hard kill

.github/workflows/test.yml

@@ -44,6 +44,20 @@ jobs:
 
       - name: Build
         run: make build
+
+      - name: Check gofmt
+        run: |
+          set -euo pipefail
+          go_files="$(git ls-files '*.go')"
+          if [ -z "$go_files" ]; then
+            exit 0
+          fi
+          unformatted="$(echo "$go_files" | xargs gofmt -l)"
+          if [ -n "$unformatted" ]; then
+            echo "The following files are not gofmt-formatted:"
+            echo "$unformatted"
+            exit 1
+          fi
 
       - name: Run tests
         env:
@@ -87,6 +101,21 @@ jobs:
         run: make oapi-generate
       - name: Build
         run: make build
+
+      - name: Check gofmt
+        run: |
+          set -euo pipefail
+          go_files="$(git ls-files '*.go')"
+          if [ -z "$go_files" ]; then
+            exit 0
+          fi
+          unformatted="$(echo "$go_files" | xargs gofmt -l)"
+          if [ -n "$unformatted" ]; then
+            echo "The following files are not gofmt-formatted:"
+            echo "$unformatted"
+            exit 1
+          fi
+
       - name: Run tests
         env:
           DEFAULT_HYPERVISOR: vz

cmd/api/api/devices.go

@@ -163,5 +163,3 @@ func availableDeviceToOAPI(d devices.AvailableDevice) oapi.AvailableDevice {
 		CurrentDriver: d.CurrentDriver,
 	}
 }
-
-

cmd/api/api/health.go

@@ -12,4 +12,3 @@ func (s *ApiService) GetHealth(ctx context.Context, request oapi.GetHealthReques
 		Status: oapi.Ok,
 	}, nil
 }
-

cmd/api/api/swagger.go

@@ -39,4 +39,3 @@ func SwaggerUIHandler(w http.ResponseWriter, r *http.Request) {
 </html>`
 	w.Write([]byte(html))
 }
-

cmd/api/config/config.go

@@ -68,11 +68,11 @@ type NetworkConfig struct {
 
 // CaddyConfig holds Caddy reverse-proxy / ingress settings.
 type CaddyConfig struct {
-	ListenAddress  string `koanf:"listen_address"`
-	AdminAddress   string `koanf:"admin_address"`
-	AdminPort      int    `koanf:"admin_port"`
-	InternalDNSPort int   `koanf:"internal_dns_port"`
-	StopOnShutdown bool   `koanf:"stop_on_shutdown"`
+	ListenAddress   string `koanf:"listen_address"`
+	AdminAddress    string `koanf:"admin_address"`
+	AdminPort       int    `koanf:"admin_port"`
+	InternalDNSPort int    `koanf:"internal_dns_port"`
+	StopOnShutdown  bool   `koanf:"stop_on_shutdown"`
 }
 
 // ACMEConfig holds ACME / TLS certificate settings.
@@ -128,12 +128,12 @@ type RegistryConfig struct {
 
 // LimitsConfig holds per-instance and aggregate resource limits.
 type LimitsConfig struct {
-	MaxVcpusPerInstance  int    `koanf:"max_vcpus_per_instance"`
-	MaxMemoryPerInstance string `koanf:"max_memory_per_instance"`
-	MaxTotalVolumeStorage string `koanf:"max_total_volume_storage"`
-	MaxConcurrentBuilds  int    `koanf:"max_concurrent_builds"`
-	MaxOverlaySize       string `koanf:"max_overlay_size"`
-	MaxImageStorage      float64 `koanf:"max_image_storage"`
+	MaxVcpusPerInstance   int     `koanf:"max_vcpus_per_instance"`
+	MaxMemoryPerInstance  string  `koanf:"max_memory_per_instance"`
+	MaxTotalVolumeStorage string  `koanf:"max_total_volume_storage"`
+	MaxConcurrentBuilds   int     `koanf:"max_concurrent_builds"`
+	MaxOverlaySize        string  `koanf:"max_overlay_size"`
+	MaxImageStorage       float64 `koanf:"max_image_storage"`
 }
 
 // OversubscriptionConfig holds oversubscription ratios (1.0 = no oversubscription).
@@ -170,19 +170,19 @@ type Config struct {
 	Env       string `koanf:"env"`
 	Version   string `koanf:"version"`
 
-	Network        NetworkConfig          `koanf:"network"`
-	Caddy          CaddyConfig            `koanf:"caddy"`
-	ACME           ACMEConfig             `koanf:"acme"`
-	API            APIConfig              `koanf:"api"`
-	Otel           OtelConfig             `koanf:"otel"`
-	Logging        LoggingConfig          `koanf:"logging"`
-	Build          BuildConfig            `koanf:"build"`
-	Registry       RegistryConfig         `koanf:"registry"`
-	Limits         LimitsConfig           `koanf:"limits"`
+	Network          NetworkConfig          `koanf:"network"`
+	Caddy            CaddyConfig            `koanf:"caddy"`
+	ACME             ACMEConfig             `koanf:"acme"`
+	API              APIConfig              `koanf:"api"`
+	Otel             OtelConfig             `koanf:"otel"`
+	Logging          LoggingConfig          `koanf:"logging"`
+	Build            BuildConfig            `koanf:"build"`
+	Registry         RegistryConfig         `koanf:"registry"`
+	Limits           LimitsConfig           `koanf:"limits"`
 	Oversubscription OversubscriptionConfig `koanf:"oversubscription"`
-	Capacity       CapacityConfig         `koanf:"capacity"`
-	Hypervisor     HypervisorConfig       `koanf:"hypervisor"`
-	GPU            GPUConfig              `koanf:"gpu"`
+	Capacity         CapacityConfig         `koanf:"capacity"`
+	Hypervisor       HypervisorConfig       `koanf:"hypervisor"`
+	GPU              GPUConfig              `koanf:"gpu"`
 }
 
 // GetDefaultConfigPaths returns the default config file paths to search.
@@ -201,7 +201,6 @@ func GetDefaultConfigPaths() []string {
 	}
 }
 
-
 // defaultConfig returns a Config struct with all default values set.
 func defaultConfig() *Config {
 	return &Config{

cmd/api/main.go

@@ -469,4 +469,3 @@ func run() error {
 	slog.Info("all goroutines finished")
 	return err
 }
-

lib/builds/builder_agent/main.go

@@ -50,8 +50,8 @@ type BuildConfig struct {
 	Secrets          []SecretRef       `json:"secrets,omitempty"`
 	TimeoutSeconds   int               `json:"timeout_seconds"`
 	NetworkMode      string            `json:"network_mode"`
-	IsAdminBuild   bool   `json:"is_admin_build,omitempty"`
-	GlobalCacheKey string `json:"global_cache_key,omitempty"`
+	IsAdminBuild     bool              `json:"is_admin_build,omitempty"`
+	GlobalCacheKey   string            `json:"global_cache_key,omitempty"`
 }
 
 // SecretRef references a secret to inject during build
@@ -599,8 +599,8 @@ func setupRegistryAuth(config *BuildConfig) error {
 	dockerConfig := map[string]interface{}{
 		"auths": map[string]interface{}{
 			registryHost: map[string]string{
-				"auth":          authValue,      // Basic auth: base64(jwt:)
-				"identitytoken": token,          // JWT directly for OAuth2-style auth
+				"auth":          authValue, // Basic auth: base64(jwt:)
+				"identitytoken": token,     // JWT directly for OAuth2-style auth
 			},
 		},
 		"credsStore":  "",
@@ -888,8 +888,8 @@ func runBuild(ctx context.Context, config *BuildConfig, logWriter io.Writer) (st
 	env := make([]string, 0, len(os.Environ())+3)
 	for _, e := range os.Environ() {
 		if !strings.HasPrefix(e, "DOCKER_CONFIG=") &&
-		   !strings.HasPrefix(e, "BUILDKITD_FLAGS=") &&
-		   !strings.HasPrefix(e, "HOME=") {
+			!strings.HasPrefix(e, "BUILDKITD_FLAGS=") &&
+			!strings.HasPrefix(e, "HOME=") {
 			env = append(env, e)
 		}
 	}
@@ -999,4 +999,3 @@ func getBuildkitVersion() string {
 	out, _ := cmd.Output()
 	return strings.TrimSpace(string(out))
 }
-

lib/builds/file_secret_provider.go

@@ -62,5 +62,3 @@ func (p *FileSecretProvider) GetSecrets(ctx context.Context, secretIDs []string)
 
 // Ensure FileSecretProvider implements SecretProvider
 var _ SecretProvider = (*FileSecretProvider)(nil)
-
-

lib/builds/file_secret_provider_test.go

@@ -99,5 +99,3 @@ func TestNoOpSecretProvider(t *testing.T) {
 	require.NoError(t, err)
 	assert.Empty(t, secrets)
 }
-
-

lib/builds/metrics.go

@@ -82,4 +82,3 @@ func (m *Metrics) RegisterQueueCallbacks(queue *BuildQueue, meter metric.Meter)
 	)
 	return err
 }
-

lib/builds/queue.go

@@ -168,4 +168,3 @@ func (q *BuildQueue) QueueLength() int {
 	defer q.mu.Unlock()
 	return len(q.active) + len(q.pending)
 }
-

lib/builds/queue_test.go

@@ -227,4 +227,3 @@ func TestBuildQueue_Counts(t *testing.T) {
 
 	close(done)
 }
-

lib/builds/registry_token_test.go

@@ -178,9 +178,9 @@ func TestRegistryTokenClaims_RepoAccess(t *testing.T) {
 	})
 
 	t.Run("IsPullAllowedForRepo", func(t *testing.T) {
-		assert.True(t, claims.IsPullAllowedForRepo("builds/abc123"))   // push implies pull
+		assert.True(t, claims.IsPullAllowedForRepo("builds/abc123")) // push implies pull
 		assert.True(t, claims.IsPullAllowedForRepo("cache/global/node"))
-		assert.True(t, claims.IsPullAllowedForRepo("cache/tenant-x"))  // push implies pull
+		assert.True(t, claims.IsPullAllowedForRepo("cache/tenant-x")) // push implies pull
 		assert.False(t, claims.IsPullAllowedForRepo("builds/other"))
 	})
 

lib/devices/errors.go

@@ -36,5 +36,3 @@ var (
 	// ErrIOMMUGroupConflict is returned when not all devices in IOMMU group can be passed through
 	ErrIOMMUGroupConflict = errors.New("IOMMU group contains other devices that must also be passed through")
 )
-
-

lib/devices/manager.go

@@ -10,9 +10,9 @@ import (
 	"sync"
 	"time"
 
-	"github.com/nrednav/cuid2"
 	"github.com/kernel/hypeman/lib/logger"
 	"github.com/kernel/hypeman/lib/paths"
+	"github.com/nrednav/cuid2"
 )
 
 // InstanceLivenessChecker provides a way to check if an instance is running.

lib/devices/manager_test.go

@@ -161,5 +161,3 @@ func TestErrors(t *testing.T) {
 		assert.Contains(t, ErrInvalidName.Error(), "pattern")
 	})
 }
-
-