Disable default hotplug memory allocation#106
Merged
sjmiller609 merged 4 commits intomainfrom Feb 26, 2026
Merged
Conversation
✱ Stainless preview buildsThis PR will update the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hotplug_size, leaving it zero unless explicitly requestedTesting
Note
Medium Risk
Changes instance-creation resource defaults (memory allocation behavior) and API contract around
hotplug_size, which could affect existing clients’ sizing expectations but is localized and covered by a new test.Overview
Stops implicitly allocating 3GB of hotplug memory when
hotplug_sizeis omitted during instance creation; hotplug memory now remains0unless explicitly requested, and responses reflect this.Updates OpenAPI/docs and domain comments to match the new semantics, adds a regression test asserting the omitted-
hotplug_sizepath passes0, and tweaks CI/tooling: pins Go to1.25.4, ensures Linux CI installse2fsprogs/iptables, and forces a stablePATHundersudoformake test-linux.Written by Cursor Bugbot for commit 9ce1996. This will update automatically on new commits. Configure here.