-
Notifications
You must be signed in to change notification settings - Fork 5
Get mouse position, GPU mode browsers #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+111
−14
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6336f16
CLI: Update hypeman SDK to a897d4c032e104d1f60b1f29415b8f691cd818bb a…
kernel-internal[bot] 3f54109
Merge main into cli-coverage-update
kernel-internal[bot] 1d5b939
feat(browsers): add computer get-mouse-position and batch commands
kernel-internal[bot] fe7b346
chore: remove all hypeman commands and dependency
cursoragent ef63bc4
Merge main into cli-coverage-update
kernel-internal[bot] 1730338
Update Go SDK to v0.35.0
kernel-internal[bot] 7f6d156
Add support for gpu
sjmiller609 b9dd123
fix: correct --actions flag help text to match expected JSON shape
masnwilliams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON output re-marshals struct instead of using raw API response
Low Severity
ComputerGetMousePositionusesjson.NewEncoder/enc.Encode(res)for its--output jsonpath, while every other command in the file consistently usesutil.PrintPrettyJSON. That utility explicitly callsRawJSON()on the SDK response to preserve the original API response and avoid zero-value fields that appear when re-marshaling the Go struct (as noted in its own doc comment). Re-marshaling viaenc.Encodemay produce different output — extra zero-value fields, missing unmapped fields — breaking consistency with all other--output jsoncommands.