Openssl Workflow Fix#12
Open
araustin01 wants to merge 1 commit into
Open
Conversation
araustin01
added
the
bug
There was a problem hiding this comment.
Pull request overview
Reintroduces an OpenSSL “pre-build” step in CI workflows, intended to ensure OpenSSL-generated artifacts are available/cached before downstream build steps run.
Changes:
- Add
zig buildstep inbuild_linux.yamlbefore building the static library. - Add
zig buildstep inbuild_examples.yamlbefore building examples.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/build_linux.yaml | Adds an OpenSSL pre-build step prior to the linux static build. |
| .github/workflows/build_examples.yaml | Adds an OpenSSL pre-build step prior to building examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
+32
| - name: ensure openssl generate step cached | ||
| run: | | ||
| zig build | ||
| working-directory: lib/openssl | ||
|
|
|
|
||
| - name: ensure openssl generate step cached | ||
| run: | | ||
| zig build |
Comment on lines
+28
to
+32
| - name: ensure openssl generate step cached | ||
| run: | | ||
| zig build | ||
| working-directory: lib/openssl | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upstream sync removes the openssl step in the workflow which breaks the build workflow downstream. This adds it back.