Mikek openshift#11
Open
mkrygeri wants to merge 3 commits into
Open
Conversation
…to support openshift deployment
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds OpenShift-specific Helm rendering for kagent (restricted SCC compatibility and optional SCC creation) and introduces an optional Service + health-check port exposure to support kproxy-style UDP intake deployments.
Changes:
- Add
openshift.*values plus templates/helpers to render OpenShift-compatible pod/container security contexts and (optionally) a SecurityContextConstraints resource. - Add configurable health-check server settings and support for exposing container ports + an optional Kubernetes Service (e.g., LoadBalancer with TCP health + UDP intake).
- Add Helm unit tests, docs, and CI template-render scenarios for OpenShift and kproxy load balancer configurations.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
values.yaml |
Adds OpenShift, healthCheck, extra ports, and Service configuration defaults. |
templates/_helpers.tpl |
Adds OpenShift SCC naming helper, OpenShift-aware security context helpers, and health/ports rendering logic in the container spec. |
templates/service.yaml |
New optional Service template driven by service.* values. |
templates/openshift-scc.yaml |
New optional SecurityContextConstraints template for OpenShift. |
contracts/values.schema.json |
Extends values schema for OpenShift, Service ports, and extra container ports. |
tests/service_test.yaml |
Adds unit coverage for Service rendering and port/env behavior for kproxy scenarios. |
tests/openshift_test.yaml |
Adds unit coverage for OpenShift restricted-compatible security contexts and SCC rendering. |
README.md |
Documents OpenShift usage and kproxy/load balancer configuration patterns. |
docs/openshift.md |
Adds a dedicated OpenShift deployment guide (restricted SCC + optional custom SCC). |
docs/kproxy-loadbalancer-values.yaml |
Provides an example values file for kproxy with a load balancer. |
.github/workflows/ci.yaml |
Adds template-render scenarios for OpenShift and kproxy load balancer configurations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+67
| {{- default (printf "%s-scc" (include "kagent.fullname" .)) .Values.openshift.securityContextConstraints.name | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} |
| value: "/opt/ua/keys" | ||
| - name: K_K8S_HELM | ||
| value: "true" | ||
| # Health check server configuration (auto-enabled when probes are enabled) |
Comment on lines
+35
to
+36
| users: | ||
| - system:serviceaccount:{{ .Release.Namespace }}:{{ include "kagent.serviceAccountName" . }} |
| memory: 4096Mi | ||
|
|
||
| # Extra container ports to expose on the kagent container. | ||
| # The health check port is added automatically when kagent.healthCheck or probes are enabled. |
|
+1 for this. We don't use openshift however we need our kubernetes deployment of kagent to have a LoadBalancer service to ingress flow traffic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Openshift in Kagent Kubenetes HELM deployment