Skip to content

Support Ruby 3 kwyword arguments in macro-style definition #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenn merged 1 commit into from
Aug 23, 2025
Merged

Support Ruby 3 kwyword arguments in macro-style definition #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/redis_mutex/macro.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ def method_added(target)
raise ArgumentError, "You are trying to lock on unknown arguments: #{unknown_arguments.join(', ')}"
end

define_method(with_method) do |*args|
define_method(with_method) do |*args, **kwargs|
named_arguments = Hash[target_argument_names.zip(args)]
arguments = mutex_arguments.map { |name| named_arguments.fetch(name) }
arguments = mutex_arguments.map { |name| named_arguments.fetch(name) } + kwargs.values
key = format(
"%<class>s#%<target>s:%<arguments>s",
class: self.class.name,
Expand All @@ -46,10 +46,10 @@ def method_added(target)
)
begin
RedisMutex.with_lock(key, options) do
send(without_method, *args)
send(without_method, *args, **kwargs)
end
rescue RedisMutex::LockError
send(after_method, *args) if respond_to?(after_method)
send(after_method, *args, **kwargs) if respond_to?(after_method)
end
end

Expand Down