fix(selfupdate): accept dot-slash checksum paths - #66
Merged
Conversation
The self-update checksum parser promises sha256sum-style input, but GNU sha256sum emits ./-prefixed names when invoked with a ./ glob. Exact filename matching then discarded valid checksums and caused updates to fail before archive download. Normalize one leading ./ after the optional binary-mode marker while preserving strict asset-name matching. Generated with Codex
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ExtractChecksumdocuments sha256sum-style input, butsha256sum -- ./*emits./filenameentries. The parser strips binary-mode*markers but compares./filenameliterally against the archive name, so valid checksum manifests can be treated as missing.Behavior
Normalize one leading
./after the optional*marker and cover both forms in the parser table. This preserves strict exact matching while accepting the path spelling emitted by GNU sha256sum.