Prevent launch picker flash during agent startup - #867
Merged
Conversation
roborev: Combined Review (
|
roborev: Combined Review (
|
roborev: Combined Review (
|
A PR create-and-launch can expose an empty ready runtime before the selected agent intent reaches the embedded workspace view. If the fallback launcher has already mounted, leaving it open until the session appears shows a redundant choice after the user already chose an agent.\n\nRetract only an automatically opened fallback when a queued explicit launch becomes pending. Manual launchers remain open across failures so their retry behavior is unchanged.\n\nValidation: WorkspaceTerminalView unit suite (122 tests), isolated create-and-launch Playwright flow in Chromium and Firefox, frontend type checks, Effect diagnostics, lint, formatting, and context-sync. Generated with Codex (gpt-5.6-sol) Co-authored-by: Codex <noreply@openai.com>
The UTC maintainer flow treated an optimistic button swap as proof that the provider state mutation had settled. Under CI load, its direct API read could overtake the POST and observe the previous state, alternating between close and reopen failures across retries. Wait for the exact successful state response before checking persisted PR or issue data, while retaining the UI assertions for presentation behavior. Validation: focused Chromium issue flow passed 10 consecutive runs; full UTC Playwright spec passed 6/6 across Chromium and Firefox; full frontend unit suite passed 3,887 tests with 2 expected skips. Generated with Codex (gpt-5.6-sol) Co-authored-by: Codex <noreply@openai.com>
Selecting an agent during workspace creation must be one uninterrupted intent: the automatic launcher cannot become visible between workspace publication and agent startup. Capturing the approved design before implementation makes the never-mounted contract, failure recovery, and verification boundary explicit. This design is transient and will be removed after its durable contracts are implemented and captured in the existing context documentation. Generated with Codex (gpt-5.6-sol) Co-authored-by: Codex <noreply@openai.com>
kenn-forge context validation deliberately forbids retaining implementation design specs under docs/superpowers. Remove the transient design from the tracked tree so internal planning cannot enter documentation staging; the approved contract remains in the local ignored task workspace until implementation promotes only durable invariants. Generated with Codex (gpt-5.6-sol) Co-authored-by: Codex <noreply@openai.com>
Selecting an agent while creating a workspace is one accepted command, but the earlier fallback could still mount before the workspace-scoped launch queue became authoritative. That made a redundant picker observable even though the user had already chosen an agent. Carry the target from item-scoped admission through workspace-ID promotion and gate only automatic launcher rendering. Plain creation still gets its empty-workspace picker, while manually used launchers keep their retry behavior. Validation: full frontend unit suite (3,889 passed, 2 skipped); full create-and-launch Playwright spec (8 passed across Chromium and Firefox); frontend checks; repository lint; context-sync. Generated with Codex (gpt-5.6-sol) Co-authored-by: Codex <noreply@openai.com>
mariusvniekerk
force-pushed
the
t3code/fix-workspace-modal-flash
branch
from
August 10, 2026 02:52
0f1555e to
ee97df7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generated by a clanker