fix: allow deletion of pre-marker workspaces - #865
Merged
Conversation
Workspaces created before ownership markers remain valid Git worktrees but cannot be deleted or retried after upgrading. The cleanup contract now treats an exact live registration in the persisted workspace repository as sufficient authority while retaining repository-identity and locked recheck protections. Generated with Codex (gpt-5.6-sol) Co-authored-by: Codex <198982749+openai-codex@users.noreply.github.com>
Workspaces created before ownership metadata was introduced remained valid Git worktrees but became impossible to delete or retry after upgrading. Treating the persisted repository's live registration as cleanup authority restores those lifecycle operations without requiring a migration or manual marker repair.\n\nSame-repository replacements at the persisted path follow the workspace lifecycle. Foreign replacements and symlink targets remain preserved; symlinked paths can be forgotten without stripping the target worktree's Git metadata.\n\nValidation: make test (6,294 tests, 11 skipped); make lint-check (0 issues); full internal/workspace and internal/server/workspacetest packages. Generated with Codex (gpt-5.6-sol) Co-authored-by: Codex <198982749+openai-codex@users.noreply.github.com>
roborev: Combined Review (
|
Member
|
ah thanks...I hit this a bunch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspaces created before ownership markers remained valid Git worktrees, but delete and retry operations rejected them after an upgrade. This left workspace records stranded with no recovery path.
This change accepts the live Git registration at the persisted workspace path as cleanup authority. Same-repository replacements follow the workspace lifecycle. Foreign checkouts and symlink targets remain preserved, and retry recreates the ownership marker.
Validation
generated by a clanker