Added getWindowSize and getWindowState - #2
Open
hseliger wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two additional methods: getWindowSize to return the position and dimensions of a window in JSON format, and getWindowState to return a JSON with the states of a specific window re. maximized, fullscreen, or minimized.
This is key if trying to save a session and later restore it's state.
Also added Gnome shell versions 49 and 50, as 50 is current (at least for Fedora, which I am using) and the extension does work there.
I am not sure (and cannot easily test) if shell versions before 49 should be removed, and at some point afaik Gnome calls changed, so this current version may break in earlier shell versions.