Repository navigation
Fix console turn finish timestamps - #1858
Merged
Merged
Conversation
Collaborator
Author
|
/kelos review |
Contributor
|
🤖 Kelos Task Status Task |
gjkim42
marked this pull request as ready for review
October 29, 2026 21:39
Collaborator
Author
|
/kelos review |
Contributor
|
🤖 Kelos Reviewer Agent @gjkim42 Review SummaryVerdict: APPROVE Reviewed at head Findings Overview
FindingsNo new findings. All three findings from the previous review (at
Other paths checked, with nothing to flag:
Key takeaways
|
gjkim42
force-pushed
the
fix/console-finish-timestamps
branch
from
October 29, 2026 21:52
8a319b1 to
06fdfbc
Compare
Collaborator
Author
|
/kelos review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Console conversations only show how long a turn worked, leaving its finish time unavailable. The runtime also strips completion timestamps when preparing history for replay.
Show a readable separator such as Finished at 12:05 PM · Worked for 5m 19s. Today's turns show a short local time; earlier days include the date, with the year when it differs from the current year. The full date, seconds, and time zone are available on hover, keyboard focus, or tap. Enter toggles the details and Escape dismisses them. Failed and interrupted turns have explicit labels.
Preserve completion timestamps through recent and paginated history so finish times remain available after reconnecting. Retained history shows finish times without durations. Keep older-page replay separate from live-turn timing in the console and plain terminal, so loading earlier messages neither invents a duration for an older turn nor loses the active turn's duration. Omit unknown timestamps and recovery-generated interruption times. Update the console documentation and tests for formatting, rendering, dismissal, replay isolation, and history delivery.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Validation:
make updateandmake verifypassed.make test TEST_FLAGS="-run 'TestApplication|TestSessionPlainTerminal|TestProjectHistory|TestServerPagesProjectedHistoryItems'"passed.make testrun failed onTestCodexEntrypointUsesPersistentSessionHomeand the Codex case ofTestAgentEntrypointsPreserveSkillReferenceFiles. Both failures reproduce on the unchanged base commit15eb48ein this environment.Screenshots use the same completed-turn fixture, locale (
en-US), time zone (UTC), clock (August 8, 2026), and desktop viewport, rendered with the base and PR versions of the console code and styles.Before
After
Full timestamp and mobile views
Full timestamp with keyboard focus
Mobile (390px)
Does this PR introduce a user-facing change?
Summary by cubic
Shows each console turn's finish time before its duration, with distinct labels for completed, failed, and interrupted turns, and preserves completion timestamps in history so the finish time stays visible after reconnecting.
Written for commit 8a319b1. Summary will update on new commits.