Skip to content

Added token authentication check for loading the maven manifest#71

Open
JaySucharitakul wants to merge 4 commits intokelnos:masterfrom
JaySucharitakul:master
Open

Added token authentication check for loading the maven manifest#71
JaySucharitakul wants to merge 4 commits intokelnos:masterfrom
JaySucharitakul:master

Conversation

@JaySucharitakul
Copy link
Copy Markdown

No description provided.

Comment thread pom.xml Outdated
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala Outdated
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala Outdated
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala Outdated
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala Outdated
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala Outdated
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala Outdated
Comment thread src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala Outdated
@kelnos
Copy link
Copy Markdown
Owner

kelnos commented May 26, 2023

Looks like the build is also failing; please figure out how to resolve that as well.

Comment on lines -224 to +242
}
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change as well

@kelnos
Copy link
Copy Markdown
Owner

kelnos commented Jun 1, 2023

Looks like the build is still failing:

Error:  /home/runner/work/mima-maven-plugin/mima-maven-plugin/src/main/scala/org/spurint/maven/plugins/mima/MiMaMojo.scala:218: value setAuthentication is not a member of org.apache.maven.artifact.repository.ArtifactRepository

Not sure what's up there, but I assume some sort of dependency issue where it's pulling a version of something that's too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants