fixing release#13
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the release workflow by adding support for ARM64 Linux cross-compilation and updates the README with new features and Docker documentation.
- Adds cross-compilation toolchain installation for ARM64 Linux builds
- Updates binary stripping to use architecture-specific tools
- Expands README documentation for new features (PostgreSQL integration, API targets, Docker usage)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/release.yml |
Adds ARM64 cross-compilation support with appropriate toolchain installation and environment configuration, updates strip command to use aarch64-linux-gnu-strip for ARM64 targets |
README.md |
Updates feature list formatting (removes emojis), adds Docker usage documentation, documents PostgreSQL and API target configuration, and adds new command-line options for target system password updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+102
to
+129
| ### Docker | ||
|
|
||
| Use the ASR tool in a container: | ||
|
|
||
| ```bash | ||
| # Build from Dockerfile.example (or use the provided example) | ||
| docker build -f Dockerfile.example -t asr:latest . | ||
|
|
||
| # Run commands | ||
| docker run --rm asr:latest --help | ||
| docker run --rm -v $(pwd):/workspace asr:latest scan | ||
|
|
||
| # With environment variables | ||
| docker run --rm \ | ||
| -e VAULT_ADDR=http://vault:8200 \ | ||
| -e VAULT_TOKEN=your-token \ | ||
| -e SECRET_BACKEND=vault \ | ||
| asr:latest auto | ||
|
|
||
| # Build specific version | ||
| docker build -f Dockerfile.example --build-arg ASR_VERSION=v1.0.0 -t asr:v1.0.0 . | ||
| ``` | ||
|
|
||
| The Dockerfile will: | ||
| 1. Try to download pre-built binaries from GitHub releases | ||
| 2. Fall back to building from source if binaries aren't available | ||
| 3. Support both x86_64 and ARM64 architectures | ||
|
|
There was a problem hiding this comment.
The README documents Docker usage with Dockerfile.example (lines 107-108, 122), but this file doesn't exist in the repository. Either add the Dockerfile.example file or remove the Docker documentation section until the Dockerfile is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.