Skip to content

Require tests before manual deploy#5

Merged
keithataylor merged 1 commit into
mainfrom
ci/require-tests-before-deploy
May 22, 2026
Merged

Require tests before manual deploy#5
keithataylor merged 1 commit into
mainfrom
ci/require-tests-before-deploy

Conversation

@keithataylor
Copy link
Copy Markdown
Owner

Summary

  • Add a pre-deploy gate to the manual ECS deploy workflow
  • Grant the deploy workflow checks: read permission so it can inspect commit check runs
  • Fail deployment early unless the required test check has passed for the exact commit SHA being deployed
  • Keep the existing SHA-tagged Docker image build/push and ECS deployment flow unchanged

Why

This prevents a manual deploy from running against a commit whose CI tests have failed, have not run, or are still pending.

Verified

  • git diff --check
  • Workflow change is limited to .github/workflows/deploy.yml

@keithataylor keithataylor merged commit 35285c6 into main May 22, 2026
2 checks passed
@keithataylor keithataylor deleted the ci/require-tests-before-deploy branch May 22, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant