fix: copy registry key before move and fix ThreadPool wait race - #7
Merged
Merged
Conversation
std::move on the object argument can be evaluated before the id sub-expression, leaving the key empty and causing all JSON entries to overwrite each other. Copy the key explicitly before the move.
The active counter was incremented after popping the task and releasing the queue mutex. This allowed waitAll() to observe an empty queue and zero active threads while a worker was about to start a task, causing runAll() to return and destroy the result mutex before the worker used it. Increment active_ under the lock before releasing the task, so waitAll() only returns when no worker owns an in-flight task. Co-Authored-By: Claude <noreply@anthropic.com>
kegouro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.