Skip to content

fix(zcash): forward Ironwood signing metadata - #58

Draft
BitHighlander wants to merge 3 commits into
masterfrom
agent/zcash-ironwood
Draft

fix(zcash): forward Ironwood signing metadata#58
BitHighlander wants to merge 3 commits into
masterfrom
agent/zcash-ironwood

Conversation

@BitHighlander

@BitHighlander BitHighlander commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • forward the NU6.3 Ironwood pool selector and fifth transaction digest in ZcashSignPCZT
  • consume the complete published @bithighlander/device-protocol@7.17.0 package through the established @keepkey/device-protocol npm alias
  • verify transparent shielding returns zero Ironwood spend signatures, while deshielding returns only the real-spend signature

Why

Vault was still loading generated v5/Orchard client code. The sidecar could build a v6 Ironwood transaction, but hdwallet omitted shielded_pool and ironwood_digest, so the device signed the old request shape and the resulting transaction was rejected by NU6.3 consensus.

The BitHighlander package carries the complete staged protocol bindings. The @keepkey/device-protocol package remains reserved for publication after the protocol changes merge to upstream master.

Validation

  • yarn build
  • yarn lint
  • yarn test --runInBand --coverage=false — 112/112 passing
  • installed npm artifact reports @bithighlander/device-protocol@7.17.0
  • Zcash transport tests assert tx v6, version group d884b698, branch 37a5165b, Ironwood pool enum, digest field 20, and compact real-spend signature counts
  • successful mainnet shield transaction: ac7f54975154f9c242a49fa151bcbc2badbb7591a8877ff9f75dbba305fdf2fd, mined in block 3430876

Draft pending final release-train review.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hdwallet-sandbox Ready Ready Preview Jul 31, 2026 5:37am

Request Review

Restore the established @bithighlander/device-protocol npm flow at exact version 7.17.0 and remove the temporary Git dependency source-generation path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant