Skip to content

fix(build): generate bindings for git dependencies - #116

Merged
BitHighlander merged 1 commit into
up/release-protocolfrom
agent/build-git-dependencies
Jul 31, 2026
Merged

fix(build): generate bindings for git dependencies#116
BitHighlander merged 1 commit into
up/release-protocolfrom
agent/build-git-dependencies

Conversation

@BitHighlander

Copy link
Copy Markdown
Collaborator

Summary

  • generate JavaScript and TypeScript bindings during the package prepare lifecycle
  • make exact Git-SHA dependencies consumable without a published fork package
  • make Protocol CI assert that a normal npm install creates the required bindings

Root cause

The staging SOP requires hdwallet to resolve the exact canonical device-protocol Git commit. A clean Yarn Git dependency install of the current staging SHA produced only lib/.keep because the repository had no prepare lifecycle. That made the Git pin unusable and forced consumers back to a separately published artifact.

Validation

  • fresh node:20-bookworm container: npm ci generated all bindings through prepare
  • exact GitHub commit installed through Yarn in a scratch consumer
  • installed messages, Solana, and Zcash bindings are present
  • Ironwood fields 19/20 and boolean serialization round-trip from the installed Git dependency

No protobuf wire definitions change. No package publish is involved.

@BitHighlander
BitHighlander marked this pull request as ready for review July 31, 2026 23:43
@BitHighlander
BitHighlander merged commit b13391c into up/release-protocol Jul 31, 2026
3 of 4 checks passed
@BitHighlander
BitHighlander deleted the agent/build-git-dependencies branch July 31, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant