enums: allow custom to string implementations - #34
Open
dirkredeye wants to merge 1 commit into
Open
Conversation
As per the [enum spec](https://docs.oracle.com/javase/7/docs/api/java/lang/Enum.html) * name() is final and can't change. It refers to the exact defined name of the constant, as declared in the enum. * toString() is arbitrary and can be developer overridden. It defaults to name() So, this should use name() instead of toString(), in-case a developer (today, me) overrides the toString of an enum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the enum spec
So, this should use name() instead of toString(), in-case a developer (today, me) overrides the toString of an enum.
Also removes some strange behaviour with
_-in enums?