Skip to content

Conversation

@kudj
Copy link
Contributor

@kudj kudj commented Aug 18, 2025

Fixed files input mapping
Added missing s3 and abs staging for tables

@kudj kudj requested review from a team and Copilot August 18, 2025 07:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the files input mapping configuration and adds support for S3 and Azure Blob Storage (ABS) staging configurations for table definitions. The fix corrects an incorrect reference from 'output' to 'input' in the configuration path, and enhances the TableDefinition class to handle storage staging information.

  • Fixed incorrect configuration path for files input mapping (changed from storage.output.files to storage.input.files)
  • Added S3 and ABS staging support to TableDefinition class with proper parameter handling
  • Added comprehensive test coverage for both S3 and ABS staging functionality

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/keboola/component/interface.py Fixed files input mapping configuration path bug
src/keboola/component/dao.py Added S3 and ABS staging parameters to TableDefinition class
tests/test_dao.py Added test cases for S3 and ABS staging functionality
tests/data_examples/data_storage_staging_s3/* Added test data for S3 staging scenarios
tests/data_examples/data_storage_staging_abs/* Added test data for ABS staging scenarios
setup.py Bumped version to reflect the changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kudj kudj force-pushed the fix/files-input-mapping branch from 6db3143 to fcba24b Compare August 18, 2025 07:38
Copy link
Contributor

@soustruh soustruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@kudj kudj merged commit 7cba656 into main Aug 18, 2025
4 checks passed
@kudj kudj deleted the fix/files-input-mapping branch August 18, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants