Update readme #79
Merged
Update readme #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated functions from examples. Add actual functions to examples.
kudj
reviewed
May 26, 2025
README.md
Outdated
| incremental=True # Enable incremental loading | ||
| ) | ||
|
|
||
| # Define columns with their data types |
Contributor
There was a problem hiding this comment.
here the better name would be add columns with default data types
kudj
reviewed
May 26, 2025
| ci = CommonInterface() | ||
|
|
||
| # Create output table definition with schema | ||
| out_table = ci.create_out_table_definition( |
Contributor
There was a problem hiding this comment.
this works, just because back compatibility with old version (the primary_key without defined schema or columns)
cleaner solution will be
a) either create empty(without schema) table definition and add columns like in the example
b) to prepare the schema first and then create table definition from it for example here
kudj
requested changes
May 26, 2025
Contributor
kudj
left a comment
kudj
left a comment
There was a problem hiding this comment.
nice documentation improvement 👍, just please fix two flaws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated functions from examples. Add actual functions to examples.
Task: https://keboola.atlassian.net/browse/CFT-3469