fix: move Solana deps to [dependencies], add spl-associated-token-account, fix SPL transfer#37
Open
knoal wants to merge 2 commits into
Open
fix: move Solana deps to [dependencies], add spl-associated-token-account, fix SPL transfer#37knoal wants to merge 2 commits into
knoal wants to merge 2 commits into
Conversation
- Add SolanaChain struct with RPC client - Implement connect, balance, SOL transfer, SPL token transfer - Add Solana to Chain enum with chain_id, default_rpc, native_token, explorer - Add solana-client, solana-sdk, spl-token dependencies - Closes kcolbchain#22
…associated-token-account, fix SPL transfer account ordering - Move solana-client, solana-sdk, spl-token, anyhow from [dev-dependencies] to [dependencies] - Add spl-associated-token-account crate for get_associated_token_address - Fix transfer_spl_token: use ATA addresses (from_ata/to_ata) instead of raw pubkeys, correct account order (source_ata, dest_ata, owner, amount) - Fix spl_token::id() → spl_token::ID (uppercase constant)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes for PR #34:
solana-client,solana-sdk,spl-token, andanyhowfrom[dev-dependencies]to[dependencies]so the library can compile with Solana support.spl-associated-token-account = "4"dependency forget_associated_token_addressused intransfer_spl_token.spl_token::id()function. Fixed to:get_associated_token_addressto derive proper ATA source/destination addresses from mint + walletsspl_token::ID(uppercase constant) instead ofspl_token::id()Compiles cleanly with one deprecation warning (solana_sdk::system_instruction deprecated, tracked separately).