fix: escape # character to prevent shell comment interpretation#16
Open
Yanhu007 wants to merge 1 commit intokballard:masterfrom
Open
fix: escape # character to prevent shell comment interpretation#16Yanhu007 wants to merge 1 commit intokballard:masterfrom
Yanhu007 wants to merge 1 commit intokballard:masterfrom
Conversation
The # character starts a comment in shell when it appears at the
beginning of a word. shellquote.Join("cd", "#metoo") produced
"cd #metoo" which shell interprets as "cd" with a comment,
silently ignoring the argument.
Add # to specialChars so it gets backslash-escaped.
Fixes kballard#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
Problem
shellquote.Join("cd", "#metoo")producescd #metoo. When passed to/bin/sh, the#metoopart is interpreted as a comment and silently discarded:Fix
Add
#tospecialCharsso it gets backslash-escaped:All existing tests pass.