Skip to content

refactor: replaced <a> tags with <Link> components#30

Open
Rashmitharaka1 wants to merge 2 commits into
devfrom
refactor/navbar-links
Open

refactor: replaced <a> tags with <Link> components#30
Rashmitharaka1 wants to merge 2 commits into
devfrom
refactor/navbar-links

Conversation

@Rashmitharaka1
Copy link
Copy Markdown
Collaborator

Replaced all tags with components from react-router-dom to ensure proper client-side routing and avoid full page reloads in the React SPA.

Copy link
Copy Markdown
Collaborator

@pabasara20 pabasara20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change the logic on the SEARCH icon!

@pabasara20 pabasara20 requested a review from kavindalj April 18, 2025 20:22
pabasara20

This comment was marked as duplicate.

Copy link
Copy Markdown
Owner

@kavindalj kavindalj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add logic for SEARCH

@Rashmitharaka1
Copy link
Copy Markdown
Collaborator Author

I've fixed the issue with the SEARCH icon logic. Please review again.

@Rashmitharaka1 Rashmitharaka1 force-pushed the refactor/navbar-links branch from 3adb878 to 7c5cece Compare March 16, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants