Don't report benign multipart parse errors in request log middleware#94
Open
bbliem wants to merge 1 commit into
Open
Don't report benign multipart parse errors in request log middleware#94bbliem wants to merge 1 commit into
bbliem wants to merge 1 commit into
Conversation
Accessing request.FILES in the request-logging middleware forces Django to parse the multipart body. Malformed or oversized bodies (e.g. gzip'd Next.js server actions POSTed to /) raise MultiPartParserError/RequestDataTooBig/ TooManyFieldsSent, which were caught by the catch-all handler and reported to Sentry as application errors (WATCH-BACKEND-6V3). Catch these client-triggered parse errors explicitly and skip logging without capturing them to Sentry. Fixes WATCH-BACKEND-6V3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing request.FILES in the request-logging middleware forces Django to parse the multipart body. Malformed or oversized bodies (e.g. gzip'd Next.js server actions POSTed to /) raise MultiPartParserError/RequestDataTooBig/ TooManyFieldsSent, which were caught by the catch-all handler and reported to Sentry as application errors (WATCH-BACKEND-6V3).
Catch these client-triggered parse errors explicitly and skip logging without capturing them to Sentry.
Fixes WATCH-BACKEND-6V3