feat(ui): add layout primitives and SSR smoke - #5
Merged
Merged
Conversation
16 of 21 tasks
kattsushi
added a commit
that referenced
this pull request
May 22, 2026
* chore(ui): open package feature chain * feat(ui): scaffold package and shadcn routing (#3) * feat(ui): add Zaidan Storybook baseline Merge PR 2 into the UI package tracker branch. * feat(ui): add layout primitives and SSR smoke (#5) * feat(ui): add component subpath exports (#6) * feat(ui): add component subpath exports * style(ui): format subpath smoke test * feat(ui): add interaction utilities (#7) * feat(ui): add interaction utilities * fix(ui): use Zaidan Sonner toast * feat(ui): add data table components (#8) * fix(ui): preserve data filter input focus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of tracker #2. Targets
feat/ui-package.PR Type
Summary
@os-copilot/ui.Chain Context
Scope
Included:
CenterStackGridFloatGridPatternDeferred intentionally:
data-table/data-table-filtersbecause they need a TanStack Table dependency/API decision.toastbecause it needs a Sonner dependency/API decision.copy-id-buttonbecause clipboard behavior and async feedback deserve separate review.marqueebecause motion/reduced-motion behavior deserves separate review.Changes
packages/ui/src/components/ui/{center,stack,grid,float,grid-pattern}.tsxpackages/ui/src/stories/ui/*packages/ui/src/index.tspackages/ui/src/testing/tree-shaking-smoke.test.tspackages/ui/src/testing/ssr-*.tsxTest Plan
pnpm exec dprint check packages/ui/src packages/ui/vitest.config.tspnpm exec oxlint packages/ui/srcpnpm nx test ui --runpnpm nx typecheck uipnpm nx build uipnpm nx build-storybook uiNotes
@os-copilot/ui/components/ui/*wildcard exports cover the new primitives. This PR does not add ergonomic subpaths like@os-copilot/ui/center; onlybuttonandchartcurrently have explicit ergonomic subpaths.getNextContextId cannot be used under non-hydrating context, so true SSR smoke coverage focuses on layout/decorative/Button while overlays remain covered by SPA smoke.Window.scrollTo() methodas not implemented during tests; tests pass.Contributor Checklist
type:*labelCo-Authored-Bytrailers