Skip to content

fix(trace): bind OTLP/gRPC listener to 127.0.0.1 by default #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastiondev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(trace): bind OTLP/gRPC listener to 127.0.0.1 by default #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ea3054
fix: bind gRPC trace listener to 127.0.0.1 instead of 0.0.0.0
sebastiondev Apr 25, 2026
ee48227
test: update trace listen default-host assertion to 127.0.0.1
sebastiondev May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/planoai/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ def up(
grpc_port=tracing_port
)
console.print(
f"[green]✓[/green] Trace collector listening on [cyan]0.0.0.0:{tracing_port}[/cyan]"
f"[green]✓[/green] Trace collector listening on [cyan]127.0.0.1:{tracing_port}[/cyan]"
)
except Exception as e:
console.print(
Expand Down
4 changes: 2 additions & 2 deletions cli/planoai/trace_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ def _start_trace_listener(host: str, grpc_port: int) -> None:


def start_trace_listener_background(
host: str = "0.0.0.0", grpc_port: int = DEFAULT_GRPC_PORT
host: str = "127.0.0.1", grpc_port: int = DEFAULT_GRPC_PORT
) -> grpc.Server:
"""Start the trace server in-process and return ``grpc.Server`` handle."""
return _start_trace_server(host, grpc_port)
Expand Down Expand Up @@ -1117,7 +1117,7 @@ def trace(
)

if target == "listen" and not has_show_options:
_start_trace_listener("0.0.0.0", DEFAULT_GRPC_PORT)
_start_trace_listener("127.0.0.1", DEFAULT_GRPC_PORT)
return

if target in ("stop", "down") and not has_show_options:
Expand Down
2 changes: 1 addition & 1 deletion cli/test/test_trace_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def fake_start(host: str, port: int) -> None:
result = runner.invoke(trace, ["listen"])

assert result.exit_code == 0, result.output
assert seen == {"host": "0.0.0.0", "port": trace_cmd.DEFAULT_GRPC_PORT}
assert seen == {"host": "127.0.0.1", "port": trace_cmd.DEFAULT_GRPC_PORT}


def test_trace_down_prints_success_when_listener_stopped(runner, monkeypatch):
Expand Down