Add assert_cmd_snapshot function and Command class#461
Merged
MatthewMckee4 merged 5 commits intomainfrom Feb 11, 2026
Merged
Conversation
Adds a new `karva.Command` builder class (wrapping Rust's `std::process::Command`) and `karva.assert_cmd_snapshot()` for snapshot-testing command output (stdout, stderr, exit code) in insta-cmd style format. Also extracts inline snapshot call detection into a `find_snapshot_call()` function with a `SNAPSHOT_CALL_PATTERNS` constant for extensibility, and updates the diff renderer to use box-drawing characters (│) for the separator column.
Merging this PR will not alter performance
|
…nt_dir test Add tests for multiple filters, nested settings, filter on stderr, filter with named snapshot, and allow_duplicates combined with filters. Remove test_cmd_snapshot_current_dir which was unpredictable across OSes.
Log the platform-specific error via tracing::debug instead of including it in the Python exception, so error messages are consistent across OSes.
Avoids platform-dependent behavior from sys.executable on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
karva.Commandbuilder class wrapping Rust'sstd::process::Commandwith.arg(),.args(),.env(),.envs(),.current_dir(), and.stdin()builder methodskarva.assert_cmd_snapshot()function for snapshot-testing command output (stdout, stderr, exit code) in insta-cmd style formatfind_snapshot_call()with extensibleSNAPSHOT_CALL_PATTERNSconstant│) for separator columnTest plan
format_cmd_outputformatting