Fix 3 snapshot bugs and add edge case tests #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `base_function_name` to handle multi-digit inline line numbers by using `trim_end_matches` instead of `strip_suffix` which only strips one trailing digit - Fix `find_inline_argument` to match `assert_json_snapshot(` calls in addition to `assert_snapshot(`, enabling inline update/accept for JSON snapshots - Fix review summary to say "review finished" instead of "insta review finished" - Add unit tests for format.rs (roundtrip with dashes, malformed input) - Add integration tests for JSON inline create/accept/named, named accept/reject, counter gaps with mixed named/unnamed, and inline snapshots with backslashes and quotes
Merging this PR will not alter performance
|
Multiple unnamed `assert_snapshot()` calls in a single test now raise an error instead of silently auto-numbering. Users must either provide explicit `name=` parameters or opt in via `snapshot_settings(allow_duplicates=True)`. Named snapshots no longer consume the unnamed counter, eliminating numbering gaps (e.g. unnamed→named→unnamed now produces `-2` not `-3`). Also fixes `test_inline_snapshot_with_backslash` to use `insta::assert_snapshot!` instead of `assert!(source.contains(...))`.
When `allow_duplicates` is active, unnamed snapshots now get `-0`, `-1`, `-2` suffixes instead of bare name, `-2`, `-3`. This makes the numbering unambiguous and sequential. Single unnamed snapshots (without `allow_duplicates`) keep the bare test name with no suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
base_function_namemulti-digit inline line numbers:strip_suffix(|c| c.is_ascii_digit())only strips one trailing digit, sotest_foo_inline_15→test_foo_inline_1instead oftest_foo. Replaced withtrim_end_matchesto strip all trailing digits. This fixes prune/unreferenced detection for inline snapshots on lines >= 10.find_inline_argumentforassert_json_snapshot: The hardcoded"assert_snapshot("pattern didn't matchassert_json_snapshot(calls, so inline snapshots with JSON couldn't be updated or accepted. Now tries both patterns and picks the closest match."insta review finished"→"review finished".---content, and malformed parse inputs.Test plan
cargo nextest run -p karva_snapshot— all 65 unit tests passjust test— all 593 tests passprek run -a— all pre-commit checks pass