Split snapshot integration tests into thematic submodules #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the monolithic snapshot.rs (~3100 lines, 75 tests) into a snapshot/ directory with 10 thematic files matching the pattern used by other extension test modules (tags/, fixtures/). Also inlines verbose command construction patterns where a `let mut cmd` + separate `.arg()` call can be expressed as a single chained expression.
Merging this PR will not alter performance
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
snapshot.rs(~3100 lines, 75 tests) intosnapshot/directory with 10 thematic files:basic,commands,review,content,inline,prune,delete,filters,named,jsonlet mut cmd+.arg()patterns into single chained expressionstags/andfixtures/extension test modulesTest plan
cargo nextest run -p karva snapshot— all 75 snapshot tests passjust test— full suite (580 tests) passesprek run -a— all pre-commit checks pass