Repository navigation
PiP fixed probe + polygon return, suppress KNN warning, remove 12-node configs - #345
Merged
Merged
Conversation
jathavaan
enabled auto-merge
May 24, 2026 11:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COUNT(*)instead of containing polygons #304: PiP entrypoints now use a single fixed query point (POINT_IN_POLYGON_PROBE_WGS84) and return actual polygon rows (SELECT *) instead ofCOUNT(*).result_cardinalityandbytes_receivedmetrics now carry correct meaning per §4.3.2.UserWarninginknn_search_localwith scopedwarnings.catch_warnings(). Distance semantics unchanged.Closes #303
Closes #304
Closes #295
Test plan
point-in-polygon-lookup-duckdb-small— verify returns polygon rows, not countspoint-in-polygon-lookup-postgis-small— samepoint-in-polygon-lookup-local-small— returns GeoDataFrameknn-search-local-small— noUserWarningin logsresult_cardinalityin output reflects actual polygon count