Repository navigation
chore: one number for the model size — 2.59GB, not 2.4GB in five comments - #21
Merged
Merged
Conversation
…ents Five comments described the shipped artifact as "2.4GB" while the README and every deep dive say 2.59GB. Both were right — 2.59e9 bytes is 2.41 GiB — but nothing in the repo said so, so a reader comparing pubspec.yaml to the README had two sizes for one file and no way to reconcile them. Normalized on the decimal figure: it is what litert-community publishes, and what the docs already use fifteen times. The two Android backup-rule files carried a range rather than a stale single value. It spans the Gemma 3 1B fallback to Gemma 4 E2B, so it is now the two sizes those models are documented at — 0.58GB in model-provisioning.md, 2.59GB in on-device-inference.md — rather than a band rounded off both ends. Comments only; no executable line changed. `dart format` reports 0 changed and `flutter analyze` no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five comments described the shipped Gemma 4 E2B artifact as "2.4GB" while the README and every deep dive say 2.59GB. Both were right — 2.59e9 bytes is 2.41 GiB — but nothing in the repo said so, so a reader comparing
pubspec.yamlto the README had two sizes for one file and no way to reconcile them.Normalized on the decimal figure: it is what
litert-communitypublishes, and what the docs already use fifteen times.pubspec.yamllib/services/models/model_downloader.dartintegration_test/model_provisioning_test.dartandroid/.../backup_rules.xmlandroid/.../data_extraction_rules.xmlThe two Android backup-rule files carried a range rather than a stale single value. It spans the Gemma 3 1B fallback to Gemma 4 E2B, so it is now the two sizes those models are documented at — 0.58GB in
docs/model-provisioning.md, 2.59GB indocs/on-device-inference.md— rather than a band rounded off both ends.git grep -E "2\.4 ?GB"now returns nothing.Comments only; no executable line changed.
dart format --set-exit-if-changedreports 0 changed andflutter analyzeno issues. The host suite was not rerun, since no executable line moved.