Skip to content

User Interface 2#1

Open
katfsw wants to merge 1 commit intomasterfrom
daniel-beggs
Open

User Interface 2#1
katfsw wants to merge 1 commit intomasterfrom
daniel-beggs

Conversation

@katfsw
Copy link
Copy Markdown
Collaborator

@katfsw katfsw commented Apr 16, 2020

No description provided.

Copy link
Copy Markdown
Collaborator Author

@katfsw katfsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Definitely meets 3 stars!

Comment thread index.html
<html lang="en">

<head>
<link rel="stylesheet" type="text/css" href="index.css">
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Awesome job linking your CSS to your HTML!

Comment thread index.html

<h1>Daniel Beggs</h1>
<div>
<ul class="nav">
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice, awesome job with the navigation and the "About", "projects" "contact" etc and linking them to their proper pages!

Comment thread index.html
<img class="main" alt="my pic" src="https://picsum.photos/200/300?grayscale">

<div class="pics">
<img alt="my pic" src="https://picsum.photos/200/300/?blur">
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job adding your pictures and displaying flex on them!

Comment thread style/index.css
margin: 40px;
}

ul.nav {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome ! looks great!

Comment thread style/index.css
border-radius: 12px;
}

li a:hover {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice CSS animation!

Comment thread style/index.css

img.pics {
display: flex;
justify-content: flex-start;
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job using flex & flex-start!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants