Skip to content

Added fix for rails 5 issue involving parse_formatted_parameters error… #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaelPoP wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added fix for rails 5 issue involving parse_formatted_parameters error… #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion lib/request_exception_handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,30 @@ def check_request_exception

# NOTE: Rails "parameters-parser" monkey patching follows :

if defined? ActionDispatch::ParamsParser::ParseError # Rails 4.x
if defined? ActionDispatch::Http::Parameters # Rails 5.x
module ActionDispatch::Http::Parameters
alias_method 'parse_formatted_parameters_without_exception_handler', 'parse_formatted_parameters'

def parse_formatted_parameters_with_exception_handler(env)
begin
out = parse_formatted_parameters_without_exception_handler(env)
RequestExceptionHandler.reset_request_exception # make sure it's nil
out
rescue ParseError => e
e = e.original_exception
handler = RequestExceptionHandler.parse_request_parameters_exception_handler
handler ? handler.call(ActionDispatch::Request.new(env), e) : raise
rescue => e # all Exception-s get wrapped into ParseError ... but just in case
handler = RequestExceptionHandler.parse_request_parameters_exception_handler
handler ? handler.call(ActionDispatch::Request.new(env), e) : raise
end
end

alias_method 'parse_formatted_parameters', 'parse_formatted_parameters_with_exception_handler'

end

elsif defined? ActionDispatch::ParamsParser::ParseError # Rails 4.x

class ActionDispatch::ParamsParser

Expand Down