Skip to content

Support for Java vendor SAP #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nice2mitja wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for Java vendor SAP #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7196c5
Create SapResolver.java
nice2mitja Aug 24, 2023
3cee079
Update Vendor.java
nice2mitja Aug 24, 2023
712e6af
Add call test for new vendor SAP
nice2mitja Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions openwebstart/src/main/java/com/openwebstart/jvm/runtimes/Vendor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public class Vendor {
public static final Vendor BELLSOFT = new Vendor("BellSoft");
public static final Vendor AZUL = new Vendor("Azul Systems, Inc.", "Azul");
public static final Vendor ECLIPSE = new Vendor("Eclipse Adoptium", "Adoptium");
public static final Vendor SAP = new Vendor("SAP SE", "SAP");

private static final List<VendorResolver> resolver;

Expand Down
11 changes: 11 additions & 0 deletions openwebstart/src/main/java/com/openwebstart/jvm/vendor/SapResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package com.openwebstart.jvm.vendor;

import static com.openwebstart.jvm.runtimes.Vendor.SAP;

public class SapResolver extends BasicVendorResolver {

public SapResolver() {
super(SAP, "sap", "SAP SE", "SAP AG");
}

}
8 changes: 8 additions & 0 deletions openwebstart/src/test/java/com/openwebstart/jvm/runtimes/VendorManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ public void testFromString() {
checkCall.accept(BELLSOFT, "Bellsoft LIBERICA");
checkCall.accept(BELLSOFT, "BELLsoFT");
checkCall.accept(KARAKUN, "Karakun");
checkCall.accept(SAP, "sap");
checkCall.accept(SAP, "SAP");

checkCall.accept(ORACLE, "oracle ");
checkCall.accept(ORACLE, " Oracle");
Expand All @@ -44,6 +46,8 @@ public void testFromString() {
checkCall.accept(BELLSOFT, " Bellsoft LIBERICA ");
checkCall.accept(BELLSOFT, " BELLsoFT ");
checkCall.accept(KARAKUN, " Karakun ");
checkCall.accept(SAP, "sap ");
checkCall.accept(SAP, " SAP");
}

@Test
Expand All @@ -66,6 +70,8 @@ public void testFromStringOrAny() {
checkCall.accept(BELLSOFT, "Bellsoft LIBERICA");
checkCall.accept(BELLSOFT, "BELLsoFT");
checkCall.accept(KARAKUN, "Karakun");
checkCall.accept(SAP, "sap");
checkCall.accept(SAP, "SAP");

checkCall.accept(ORACLE, "oracle ");
checkCall.accept(ORACLE, " Oracle");
Expand All @@ -77,5 +83,7 @@ public void testFromStringOrAny() {
checkCall.accept(BELLSOFT, " Bellsoft LIBERICA ");
checkCall.accept(BELLSOFT, " BELLsoFT ");
checkCall.accept(KARAKUN, " Karakun ");
checkCall.accept(SAP, "sap ");
checkCall.accept(SAP, " SAP");
}
}