Note that 7 moved processing config accessors have a compatibility shim - #993
Open
coipond-writer[bot] wants to merge 1 commit into
Open
Note that 7 moved processing config accessors have a compatibility shim#993coipond-writer[bot] wants to merge 1 commit into
coipond-writer[bot] wants to merge 1 commit into
Conversation
karafka/lib/karafka/setup/config.rb:463-493 (install_processing_cg_forwarders) installs backward-compatible read/write forwarding for exactly the 7 config.internal.processing.* settings listed in this section, at their old pre-nesting location, specifically so dependents like karafka-testing keep working unmodified. The page listed these 7 alongside genuinely hard-broken constant renames under the same "Advanced Users - must update references" framing, overstating the required work: unlike the renames, these 7 still work at their old path. Added a note clarifying this. Fixes #44809.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "Internal Namespace Reorganization" section lists 7 `config.internal.processing.*` settings as moved under `config.internal.processing.consumer_groups`, under the same "Advanced Users - must update references" framing as the genuinely hard-broken constant renames listed nearby.
Why it overstates the required work
`karafka/lib/karafka/setup/config.rb:463-493` (`install_processing_cg_forwarders`) installs backward-compatible read/write forwarding for exactly these 7 settings at their old, pre-nesting location, specifically so dependents like `karafka-testing` keep working unmodified. Unlike the constant renames listed alongside them, these 7 still work at their old path.
Fix
Added a note clarifying the shim, right after the 7-item list.
Fixes #44809 (Redmine).