Fix throttler documented as computing a divided rate instead of an absolute count - #985
Open
coipond-writer[bot] wants to merge 1 commit into
Open
Conversation
…solute count pro/processing/consumer_groups/filters/throttler.rb:59-81 (#apply!) purges entries older than the window, sums the remaining counts, and compares that sum against an absolute @limit - no division anywhere, matching the code's own comment ("at most 100 messages in a 60 second rolling window"). The page described the throttler as dividing messages-in-window by window size to get a "consumption rate" and comparing that rate to the limit. Fixed to describe the actual mechanism: an absolute message-count cap within a rolling window. Fixes #44186.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
`Pro/Consumer-Groups/Rate-Limiting.md:3` said the throttler "calculates the consumption rate by dividing the number of messages consumed in the window by the window size" and compares that rate against the limit.
Why it's wrong
`pro/processing/consumer_groups/filters/throttler.rb:59-81` (`#apply!`) purges entries older than the window, sums the remaining counts, and compares that sum against an absolute `@limit` -- no division anywhere, matching the code's own comment ("at most 100 messages in a 60 second rolling window").
Fixed to describe the actual mechanism: an absolute message-count cap within a rolling window, not a computed rate.
Fixes #44186 (Redmine, confidence: likely -- independently re-confirmed against source before fixing).