Fix reducer errors misdocumented as sharing the partitioner's error event type - #984
Open
coipond-writer[bot] wants to merge 1 commit into
Open
Conversation
…vent type pro/processing/consumer_groups/parallel_segments/filters/base.rb:58-93: #partition failures instrument type "parallel_segments.partitioner.error" (line 69); #reduce failures instrument a distinct type, "parallel_segments.reducer.error" (line 89). The page claimed both share the same event type. Anyone filtering error.occurred by parallel_segments.partitioner.error to catch reducer bugs would silently miss them. Fixed to name both distinct types. Fixes #44183.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
`Pro/Consumer-Groups/Parallel-Segments.md:331` said both partitioner and reducer failures emit `error.occurred` with type `parallel_segments.partitioner.error`.
Why it's wrong
`pro/processing/consumer_groups/parallel_segments/filters/base.rb:58-93`: `#partition` failures instrument type `parallel_segments.partitioner.error` (line 69); `#reduce` failures instrument a distinct type, `parallel_segments.reducer.error` (line 89).
Anyone filtering `error.occurred` by `parallel_segments.partitioner.error` to catch reducer bugs would silently miss them.
Fixed to name both distinct types.
Fixes #44183 (Redmine).