Repository navigation
Close four gaps between the cards, list and settings and Paper - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the four gaps KAPY-13 measured between the running app and the final Paper design (5TS-0 main window, 6EV-0 settings). Part of HIS-15.
Long titles over a checklist. A card only lets its title take two lines when there is still at least 6px left between the title and whatever sits under it. On a checklist card, two lines of title used to touch the progress bar. Now the title stays on one line there and keeps a clear gap above the bar, as Paper does. Cards without a checklist still get two-line titles.
Amounts in Geist Mono. If the line under a card's title is nothing but an amount, like "₹75,60,000", the card shows it as written in the result style: Geist Mono in the result green, with Paper's 3px gap under the title. Before, such a line either fell back to Figtree, when there were no rates to price it, or showed reformatted as "75,60,000.00 INR". Lines that are calculations still show their result.
See all at the right edge. The list heading put its label in a
Flexiblenext to aSpacer, so the two split the free space and the trailing link stopped well short of the edge. The label and count now sit in anExpandedrow, so See all ends at the heading's right edge, in line with the cards.Neutral focus on the settings search.
kapyFieldDecorationtakes aneutralFocusoption, and the settings search uses it on desktop. Focusing the field no longer turns its border sage; it keeps the 1.5pxcontrolBorder, matching 6EV-0 and the list's own search field. On touch, it keeps the shared sage focus.The Pinned order still follows last edit, as agreed.
Tests and goldens.
test/riverbank_fidelity_test.darthas one test per gap. All four fail on main and pass here. The new goldendesktop_dark_pinned_cardsshows a long checklist title, See all and mono amounts together.Re-rendered goldens, each checked by eye:
desktop_dark_settingsand the_appearance_end,_shortcutsand_updatesvariants,desktop_light_settings_appearance,desktop_windows_dark_settings,desktop_windows_dark_update). The search field is focused when Settings opens, so its border went from sage to neutral.flutter analyzeis clean, and the full suite passes locally (2150 passed, 8 skipped) on Flutter 3.47.4 withpub get --enforce-lockfile, because the 3.47.2 install on this Mac is damaged.